hebcal-js icon indicating copy to clipboard operation
hebcal-js copied to clipboard

change string functions

Open sagi053 opened this issue 6 years ago • 2 comments

  1. adding week day names dictionary(hebrew and english).
  2. adding 3 string functions , spread them from toString function.
    1. getDayName - getting the hebrew day
    2. getMonthName - getting the hebrew month
    3. getYearName - getting the hebrew year.
  3. adding function to get the name of week day.
  4. adding function dateFormat - with date formatter u can get the date with any format you need. usage : let hebCalObj = new Hebcal(); let hebrewDateObj = (hebCalObj).find(new Date)[0]; if (hebrewDateObj){ weekDay = 'יום ' + hebrewDateObj.getWeekDayName(lang); hebrewDate = hebrewDateObj.dateFormat('D M',lang); }

sagi053 avatar Jul 19 '19 11:07 sagi053

I like this idea. Want to add a simple test file to the test folder? See my PR for an example of what I mean: #71

barakplasma avatar Sep 05 '19 08:09 barakplasma

I like this idea. I left a couple comments with issues. (And sorry for taking so long to respond.)

Scimonster avatar Sep 16 '19 15:09 Scimonster