Hennadii Stepanov
Hennadii Stepanov
Here is another observation. A non-native `QFileDialog` [requires](https://forum.qt.io/topic/102262/unsupported-in-the-posix-collation-implementation) ICU support, but it is disabled: https://github.com/bitcoin-core/gui/blob/7317e14a44c6efc545e6fb9bcedee7174e93a8fa/depends/packages/qt.mk#L40 As a consequence, users experience Qt warnings every time they open a filesystem dialog: ```...
@luke-jr still working on this?
@luke-jr Rebase?
> When restoring table columns, still set their minimum column width and stretch on last section Are `minimumSectionSize` and `stretchLastSection` parts of the saved state? > Regression introduced in #205...
@luke-jr The [`minimumSectionSize`](https://doc.qt.io/qt-5/qheaderview.html#minimumSectionSize-prop) and [`stretchLastSection`](https://doc.qt.io/qt-5/qheaderview.html#stretchLastSection-prop) properties of the [`QHeaderView`](https://doc.qt.io/qt-5/qheaderview.html) class are saved with [`QHeaderView::saveState`](https://doc.qt.io/qt-5/qheaderview.html#saveState) and restored with [`QHeaderView::restoreState`](https://doc.qt.io/qt-5/qheaderview.html#restoreState). > Regression introduced in #205 1. From the PR description it is...
> I guess this is more about not relying on undefined behaviour rather than a bugfix. > > Leaving the assignment prior to restoring sizes, so that users who actually...
This discussion has been inactive for a long time. Should it be closed?
@luke-jr > This discussion has been inactive for a long time. > > Should it be closed? Instead of reacting with the "thumbs down" emoji, maybe just answer questions from...
@rebroad > @luke-jr what's the difference between raising a pull on this repository vs the bitcoin repository (as per your original 15115 pull request)? Sorry to ask this here but...
cc @achow101