Hennadii Stepanov
Hennadii Stepanov
As a part of the Bitcoin Core project, `libmultiprocess` should ensure a stable build environment. Testing all available policies introduces unneeded burden for developers. Also see https://github.com/hebasto/bitcoin/pull/143.
If this PR is merged, what actions will be taken when a new CMake release comes out? What are criteria to bump the `` option?
Here are a couple of examples of policies that change the build system's behaviour depending on the CMake version in use: - https://cmake.org/cmake/help/latest/policy/CMP0117.html - https://cmake.org/cmake/help/latest/policy/CMP0141.html That is the main reason...
Here is another example of how new policies might be controversial: https://github.com/bitcoin/bitcoin/pull/31504. cc @theuni @fanquake
CI [fails](https://github.com/bitcoin-core/libmultiprocess/actions/runs/17428564111/job/49481356940): ``` make: *** No rule to make target 'tests'. ```
Here is a related upstream issue: https://gitlab.kitware.com/cmake/cmake/-/issues/25670. The regression is behavior is caused by setting `CMAKE_TRY_COMPILE_TARGET_TYPE` globally:https://github.com/bitcoin/bitcoin/blob/fc642c33ef28829eda0119a0fe39fd9bc4b84051/cmake/module/CheckSourceCompilesAndLinks.cmake#L9-L10
@furszy 3f34c04628f1cb0f59afb5176dae3a0e8d414d7d "gui: bugfix, decouple WalletModel from RPCExecutor" Maybe remove "bugfix" from the commit message, as there is no reproducible bug in the master branch?
The GUI users [may be able to temporarily override their Mac security settings to open it](https://support.apple.com/en-gb/102445#openanyway) (tested on the same machine for `Bitcoin Core.app` downloaded from https://bitcoincore.org/bin/bitcoin-core-28.0/test.rc2/bitcoin-28.0rc2-x86_64-apple-darwin.zip). UPD. Also tested...
My bad! I downloaded binaries for `x86_64` arch on `arm64` machine. They were using the Rosetta framework.
From my understanding, the issue arises because the `make` provided by Xcode does not set the `.SHELLFLAGS` variable properly. Here's an example of the output: ``` % whereis make make:...