Hennadii Stepanov
Hennadii Stepanov
Rebased due to the conflict with the merged bitcoin/bitcoin#31015.
> Concept ACK. > > ... we currently have: > > ```cmake > set_target_properties(bitcoin-chainstate PROPERTIES > SKIP_BUILD_RPATH OFF > ) > ``` > > Which I think can be removed...
Rebased due to the conflict with the merged bitcoin/bitcoin#31191.
Rebased due to the conflict with the merged https://github.com/bitcoin/bitcoin/pull/26593.
Rebased on top of the https://github.com/bitcoin/bitcoin/pull/31307 to workaround MSVC compiler issue.
@ryanofsky > Code review ACK [06ff942](https://github.com/bitcoin/bitcoin/commit/06ff9429d32943aa4debec38ea105c8af4283aec). It seems like a improvement to me overall if binaries in the build directory have the same layout as binaries in releases. I'm not...
A silent conflict has been fixed.
re https://github.com/bitcoin/bitcoin/pull/31161#issuecomment-2583073982 > @ryanofsky wrote: > > > Possibly, it might make sense to build bitcoin-chainstate.exe and bitcoinkernel.dll to libexec/ instead of bin/. > > I like that as well....
> When I do `sudo cmake --install build` on macOS 15.2 it puts the binaries in `/usr/local/bin` and `/usr/local/lib` (not `/usr/local/libexec` or `/usr/libexec`). Is that intended? Target output locations and...
Reworked per recent [feedback](https://github.com/bitcoin/bitcoin/pull/31161#issuecomment-2586587671). `libexec` is an installation path for targets whose output path is set to `libexec`.