Hennadii Stepanov
Hennadii Stepanov
Related to https://github.com/bitcoin/bitcoin/issues/31476.
> > I don't like the idea of overloading the WERROR build option with additional functionality, as this is not what users would expect. > > Can you elaborate on...
As pointed in https://github.com/bitcoin/bitcoin/pull/31724#issuecomment-2610000303, this change will break builds on systems where a toolchain does not support PIE.
What about using of CMake's [CPack](https://cmake.org/cmake/help/latest/module/CPack.html) module: ```diff --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -229,6 +229,18 @@ if(SECP256K1_BUILD_EXAMPLES) add_subdirectory(examples) endif() +set(CPACK_SOURCE_GENERATOR TBZ2 TGZ TXZ) +set(CPACK_SOURCE_IGNORE_FILES + \\.git/ + build/ + ci/...
> > Not sure, but [github.com/orgs/community/discussions/45830](https://github.com/orgs/community/discussions/45830) may be an issue... > > Oh okay, this makes `git archive` much more interesting... See #1287.
> * `git archive` may be nice because it can be recreated locally. It also makes it possible to deterministically embed some data into source files, such as the top...
Adding a source hash to the cache variable name became necessary at some point during the development of the CMake staging branch, as checks for the same flags could occur...
> This is similar to #247 but it's not sticking at "done loading" but the main core window is freezing when blocks are being validated. I verified how `ActivateBestChain` affects...
From https://github.com/bitcoin/bitcoin/issues/29293: > Seems that "connecting to peers" and the beginning of "synchronizing with network" operation block UI thread.
@maflcko Can you clear all `ccache` caches so that we can observe the CI jobs under these conditions?