bitcoin icon indicating copy to clipboard operation
bitcoin copied to clipboard

Remove unused src_dir param from run_tests

Open l0rinc opened this issue 1 year ago • 3 comments
trafficstars

Split out of https://github.com/bitcoin/bitcoin/pull/30454

The src_dir usage was removed in https://github.com/bitcoin/bitcoin/commit/a8a2e364acf55bbe18404ab21f852d52257bcb6d#diff-437d7f6e9f2229879b60aae574a8217f14c643bbf3cfa9225d8011d6d52df00cL598, making the parameter unused.

l0rinc avatar Aug 18 '24 18:08 l0rinc

We'll proceed with these changes once https://github.com/bitcoin/bitcoin/pull/30454 is landed.

hebasto avatar Aug 22 '24 09:08 hebasto

I still see the dup library warning on building

I don't expect that to be resolved anytime soon, but at least we've workarounded™ it for fuzzing on mac (was a blocker before)

l0rinc avatar Aug 22 '24 12:08 l0rinc

I don't expect that to be resolved anytime soon, but at least we've workarounded™ it for fuzzing on mac (was a blocker before)

I was aware of it, thanks! I also have pending to review #319.

pablomartin4btc avatar Aug 22 '24 12:08 pablomartin4btc

Since https://github.com/bitcoin/bitcoin/pull/30454 has been merged, further development in this repository no longer makes sense. Please consider moving this PR to the main repository.

hebasto avatar Aug 28 '24 10:08 hebasto

moved to https://github.com/bitcoin/bitcoin/pull/30733

l0rinc avatar Aug 28 '24 13:08 l0rinc