rbc icon indicating copy to clipboard operation
rbc copied to clipboard
verified publisher icon heavyai

Support strings

Open pearu opened this issue 5 years ago • 6 comments

Perhaps already have string dictionary support by inputting key_for_string, but could make nicer ux around this

pearu avatar Sep 20 '20 17:09 pearu

See Slack discussions for ideas:

  1. https://quansight.slack.com/archives/C01CAU0U1FH/p1605526178096400

pearu avatar Nov 17 '20 09:11 pearu

Related PRs:

  • https://github.com/omnisci/omniscidb-internal/pull/5492
  • https://github.com/xnd-project/rbc/pull/322

pearu avatar Jun 01 '21 11:06 pearu

Related PR:

  • https://github.com/xnd-project/rbc/pull/322

guilhermeleobas avatar Aug 10 '21 18:08 guilhermeleobas

TextEncodingNone and TextEncodingDict types are supported.

guilhermeleobas avatar Mar 31 '22 01:03 guilhermeleobas

Tests in rbc/tests/heavyai/test_text_encoding.py cover the cases where TextEncodingDict variables are passed around but we don't have tests for accessing the content of TextEncodingDict variables. In short, we should be able to define a UDF that translates a TextEncodingDict variable to TextEncodingNone return value, for instance. And vice-versa, checking if TextEncodingNone variable can be converted to TextEncodingDict return value (I imagine if the input string is not in the strings dictionary, the conversion should fail, or add a new item to the dict).

pearu avatar Mar 31 '22 06:03 pearu

PR #531 adds support for python strings

guilhermeleobas avatar Feb 25 '23 17:02 guilhermeleobas