heavyai-connector icon indicating copy to clipboard operation
heavyai-connector copied to clipboard

Namespace to encapsulate the 140 globals

Open biovisualize opened this issue 7 years ago • 0 comments

:beetle: bug

  • [x] Operating System and version: all
  • [x] Browser and version: all
  • [x] Steps to reproduce (including dashboard link):
    1. open page that loads dist/browser-connector.js
    2. open developer tools console and look at window global object.
    3. 🐞 you'll see the methods listed below in the global namespace.
  • [x] Description of issue: All the connector methods are bleeding into the global space. To at least prevent name clashes, we should use a namespace to contain them.

["copyList","copyMap","Thrift","TDatumType","TEncodingType","TExecuteMode","TTableType","TMergeType","TExpressionRangeType","TDatumVal","TDatum","TStringValue","TTypeInfo","TColumnType","TRow","TColumnData","TColumn","TStringRow","TStepResult","TRowSet","TQueryResult","TGpuDataFrame","TDBInfo","TMapDException","TRenderProperty","TCopyParams","TDetectResult","TImportStatus","TFrontendView","TServerStatus","TPixel","TPixelRowResult","TPixelTableRowResult","TPixelRows","TPixelResult","TRenderResult","TGpuMemorySummary","TMemorySummary","TTableDetails","TColumnRange","TDictionaryGeneration","TTableGeneration","TPendingQuery","TVarLen","TDataBlockPtr","TInsertData","TRawRenderPassDataResult","TRawPixelDataResult","MapD_connect_args","MapD_connect_result","MapD_disconnect_args","MapD_disconnect_result","MapD_get_server_status_args","MapD_get_server_status_result","MapD_get_tables_args","MapD_get_tables_result","MapD_get_table_details_args","MapD_get_table_details_result","MapD_get_users_args","MapD_get_users_result","MapD_get_databases_args","MapD_get_databases_result","MapD_get_version_args","MapD_get_version_result","MapD_start_heap_profile_args","MapD_start_heap_profile_result","MapD_stop_heap_profile_args","MapD_stop_heap_profile_result","MapD_get_heap_profile_args","MapD_get_heap_profile_result","MapD_get_memory_gpu_args","MapD_get_memory_gpu_result","MapD_get_memory_summary_args","MapD_get_memory_summary_result","MapD_clear_cpu_memory_args","MapD_clear_cpu_memory_result","MapD_clear_gpu_memory_args","MapD_clear_gpu_memory_result","MapD_sql_execute_args","MapD_sql_execute_result","MapD_sql_execute_gpudf_args","MapD_sql_execute_gpudf_result","MapD_interrupt_args","MapD_interrupt_result","MapD_sql_validate_args","MapD_sql_validate_result","MapD_set_execution_mode_args","MapD_set_execution_mode_result","MapD_render_vega_args","MapD_render_vega_result","MapD_get_result_row_for_pixel_args","MapD_get_result_row_for_pixel_result","MapD_get_frontend_view_args","MapD_get_frontend_view_result","MapD_get_frontend_views_args","MapD_get_frontend_views_result","MapD_create_frontend_view_args","MapD_create_frontend_view_result","MapD_delete_frontend_view_args","MapD_delete_frontend_view_result","MapD_get_link_view_args","MapD_get_link_view_result","MapD_create_link_args","MapD_create_link_result","MapD_load_table_binary_args","MapD_load_table_binary_result","MapD_load_table_args","MapD_load_table_result","MapD_detect_column_types_args","MapD_detect_column_types_result","MapD_create_table_args","MapD_create_table_result","MapD_import_table_args","MapD_import_table_result","MapD_import_geo_table_args","MapD_import_geo_table_result","MapD_import_table_status_args","MapD_import_table_status_result","MapD_start_query_args","MapD_start_query_result","MapD_execute_first_step_args","MapD_execute_first_step_result","MapD_broadcast_serialized_rows_args","MapD_broadcast_serialized_rows_result","MapD_render_vega_raw_pixels_args","MapD_render_vega_raw_pixels_result","MapD_insert_data_args","MapD_insert_data_result","MapD_get_table_descriptor_args","MapD_get_table_descriptor_result","MapD_get_row_descriptor_args","MapD_get_row_descriptor_result","MapD_render_args","MapD_render_result","MapD_get_rows_for_pixels_args","MapD_get_rows_for_pixels_result","MapD_get_row_for_pixel_args","MapD_get_row_for_pixel_result","MapDClient","Connector"]

biovisualize avatar Aug 15 '17 14:08 biovisualize