heavyai-charting icon indicating copy to clipboard operation
heavyai-charting copied to clipboard

Module builds

Open soft-boy opened this issue 7 years ago • 3 comments

Merge Checklist

:wrench: Issue(s) fixed:

  • [ ] Author referenced issue(s) fixed by this PR:
  • [ ] Fixes #0

:smoking: Smoke Test

  • [ ] Works in chrome
  • [ ] Works in firefox
  • [ ] Works in safari
  • [ ] Works in ie edge
  • [ ] Works in ie 11

:ship: Merge

  • [ ] author crafted PR's title into release-worthy commit message.

soft-boy avatar Aug 22 '17 19:08 soft-boy

Codecov Report

Merging #95 into master will increase coverage by <.1%. The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #95     +/-   ##
========================================
+ Coverage    31.5%   31.5%   +<.1%     
========================================
  Files          73      73             
  Lines        8093    8097      +4     
========================================
+ Hits         2552    2554      +2     
- Misses       5541    5543      +2
Impacted Files Coverage Δ
test/config.js 100% <100%> (ø) :arrow_up:
src/mixins/map-mixin.js 25.4% <100%> (ø) :arrow_up:
src/index.js 84.6% <33.3%> (-15.4%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b8960a...c39a135. Read the comment docs.

codecov-io avatar Aug 22 '17 19:08 codecov-io

Codecov Report

Merging #95 into master will increase coverage by <.1%. The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #95     +/-   ##
========================================
+ Coverage    31.5%   31.5%   +<.1%     
========================================
  Files          73      73             
  Lines        8093    8097      +4     
========================================
+ Hits         2552    2554      +2     
- Misses       5541    5543      +2
Impacted Files Coverage Δ
src/mixins/map-mixin.js 25.4% <100%> (ø) :arrow_up:
test/config.js 100% <100%> (ø) :arrow_up:
src/index.js 84.6% <33.3%> (-15.4%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b8960a...c39a135. Read the comment docs.

codecov-io avatar Aug 22 '17 19:08 codecov-io

Thanks for this @edwickable , we will merge this once we test this Immerse.

mrblueblue avatar Aug 25 '17 14:08 mrblueblue