simple_form icon indicating copy to clipboard operation
simple_form copied to clipboard

Published 20 hours ago • verified publisher icon heartcombo

Make error_class work on inner wrapper

Open lafeber opened this issue 3 years ago • 7 comments

Fix for https://github.com/heartcombo/simple_form/issues/1727

lafeber avatar Mar 03 '21 16:03 lafeber

@carlosantoniodasilva If you have some time to look at this, it would be greatly appreciated!

lafeber avatar Mar 12 '21 15:03 lafeber

@rafaelfranca If you have some time to look at this, it would be greatly appreciated!

lafeber avatar Mar 17 '21 13:03 lafeber

@lafeber I did get your initial ping and should've commented back that'd get to it here, that was my bad, but please be a little patient. :) Thanks!

carlosantoniodasilva avatar Mar 17 '21 13:03 carlosantoniodasilva

@carlosantoniodasilva I'm truly sorry, I didn't mean to be impatient. I appreciate all the work you put in this gem - it's one of my all time favourites.

lafeber avatar Mar 24 '21 14:03 lafeber

Hello everyone, I was wondering if you plan to merge this as we're also facing this issue.

Thanks

jeremybdk avatar Oct 26 '21 11:10 jeremybdk

This change solves some issues I was having as well, would be great if it was merged in!

HectorMF avatar Nov 29 '21 11:11 HectorMF

@rafaelfranca @lafeber I updated this PR with a fix to how we check for input's errors. Previously it wasn't properly checking it so my newly added spec was failing. I fixed that. @rafaelfranca @carlosantoniodasilva if PR looks good to you I'll merge it and will update Changelog/README afterward.

nashby avatar Oct 02 '22 14:10 nashby