devise

devise copied to clipboard

Replace [data-turbo-cache=false] with [data-turbo-temporary]

2

Following the suggestion from issue https://github.com/heartcombo/devise/issues/5662 The turbo drive's attribute `[data-turbo-cache=false]` was deprecated in favor of `data-turbo-temporary`

eduardoyutaka

## Environment - Ruby **3.2.2** - Rails **7.1.2** - Devise **4.9.3** ## Current behavior Setting up the `parent_mailer` options with ```ruby config.parent_mailer = "ApplicationMailer" ``` prevents the application from starting...

eneagoe

## Environment - Ruby **3.2.2** - Rails **7.1.2** - Devise **4.9.3** ## Current behavior The default [_error_messages.html.erb](https://github.com/heartcombo/devise/blob/main/app/views/devise/shared/_error_messages.html.erb) partial uses a deprecated Turbo attribute `data-turbo-cache=false` This attribute was deprecated on Feb...

eduardoyutaka

`confirmation_sent_at` is set regardless `skip_confirmation_notification!` method call

1

Related to https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138501#note_1686234692 User's `confirmation_sent_at` is set regardless `skip_confirmation_notification!` when creating new user.

bogdanvlviv

References the issue here: https://www.google.com/url?q=https://github.com/heartcombo/devise/issues/5498&sa=D&source=docs&ust=1701833326557472&usg=AOvVaw0rlCheHzI9Iz_DlsFU3z3V whereby, the user emails violated a potential unique constraint on emails. We can fix this by creating our own fixtures to run devise test cases.

vdheera

This PR is in response to the issue https://github.com/heartcombo/devise/issues/5591. It increases the default password length to 10 characters as opposed to the 6 characters now & it requires that a...

vdheera

In order to avoid "unpermitted parameters" errors, the password parameter is permitted by default for the `sign_in` action (see https://github.com/heartcombo/devise/pull/2440 and https://github.com/heartcombo/devise/pull/2452). Now, `Devise::SessionsController#new` creates a new resource with the...

moritzhoeppner

Using MFA with Devise, it would be great to support callable objects in the `sign_in_after_reset_password` config. Example ```ruby config.sign_in_after_reset_password = ->(resource) { !resource.mfa_enabled? } ``` Originally, I had to override...

excid3

Update friendly_token to issue Structured Secrets

3

Hey folks, I'd like to propose an update to the current implementation of `Devise#friendly_token` to use [Structured Secrets](https://github.com/chtzvt/sssecrets). I've put together a [demo](https://github.com/chtzvt/sssecrets-devise), but would like to collect feedback on...

chtzvt

"Encrypted password" is actually "Hash" of the password. Does it need to be renamed?

1

Currently, the column designated for the hashed value of the password is named "**encrypted_password**". While I understand the historical context, I've noticed that this term could potentially be a bit...

Ashwintrn