heartcombo
Make test suite work
The tests on main are not passing with Rails 7.1 onwards. At the same time, since Rails is supported 7.2 onwards and Ruby 3.1 is EOL in 2 weeks, we can drop support for older versions.
No, because the test don't pass and it doesn't make sense to make them pass for versions of Ruby and Rails that Devise shouldn't support anymore.
@carlosantoniodasilva These still pass locally with ruby 3.2 and 3.3. If this gets merged, I can look into the issues with 3.4
@gregmolnar thanks for this.
I was originally considering only dropping support to Rails < 6 in Devise, regardless of Rails currently supported versions. But that's been a while, and I've already dropped support for Rails < 7 and Ruby < 2.7 on other heartcombo/* libs (was gonna get to Devise next/soon), so I think we should stick to that same level of support for Devise here, if you don't mind.
What's in main is already cutting down multiple versions (currently released version supports all the way back to 4.1), so let's at least leave the last 2 majors on the table; cut down v4/5/6, and continue supporting v7.0+ for the time being.
This is responders setup, for reference: https://github.com/heartcombo/responders/commit/818ec078bcb37d7729db5fd34883e08ae031f038
@carlosantoniodasilva I made the test matrix the same and added back Rails 7.0 support. Can you approve the workflow to see if the whole matrix succeeds? Thanks!
@carlosantoniodasilva I fixed the issues, it passes on my fork now: https://github.com/gregmolnar/devise/actions/runs/18576202141