devise
devise copied to clipboard
Mirror rails default_sender logic
Update default_sender
logic to mirror the Rails compute_default
method.
The existing code uses instance_eval
which always passes self
in as the first argument. The examples in the Rails guides and API docs use lambdas with no arguments. With the existing Devise code this raises an ArgumentError
exception since lambda expects no arguments and one is passed.
Are there any roadblocks for merging this? It would be nice if devise were compatible with the current rails docs.
Are there any roadblocks for merging this? It would be nice if devise were compatible with the current rails docs.
we need this fix, experiencing the same issue. I'll have to create another mailer class as a workaround
@dilshod you may be able to use a proc
instead of a lambda
. I think that worked for us.
@jmschneider yes, that works, thanks