heartcombo
Regenerate BCrypt password hash on a sign in after the stretches config changes
Hello, @sergey-alekseev! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.
![sourcelevel-bot[bot] avatar](https://avatars.githubusercontent.com/in/597?v=4 "Published by a pub.dev verified publisher"){kind=small}
Some Travis CI jobs failed because of this bug – https://github.com/seattlerb/minitest/issues/803. The bug was introduced recently in the latest version. The fix is already in the minitest's master, just needs a gem version to be released.
I was able to reproduce it locally after installing Ruby 2.3 and doing bundle update (Travis does this before running bin/test).
One Ruby 2.2 Travis CI test failed because they released a gem version with both the match fix and Ruby 2.3+ requirement. So Ruby 2.2 is stuck with a buggy 5.12.0, not sure how to better fix it without additional Minitest gem updates. Started a discussion in that issue.
✅ Travis CI is green now because a Minitest's maintainer released a new gem version.
How are we tracking with this?
Is it a question to the devise owners? Can you please clarify your question? @msxavi
How are we tracking with this?
Is it a question to the devise owners? Can you please clarify your question? @msxavi
@sergey-alekseev since you are responsible for this PR, the question was meant for you.
SourceLevel has finished reviewing this Pull Request and has found:
- 6 possible new issues (including those that may have been commented here).
But beware that this branch is 14 commits behind the plataformatec:master branch, and a review of an up to date branch would produce more accurate results.
See more details about this review.
How are we tracking with this?
To be clear – I don't understand this question. @msxavi
Hey! We're interested in this feature as well, since we are currently using monkey-patches which we need to review again every time a new devise version is released and having this as part of the official code would be great!
Is there any way we can help this become a reality?
I rebased over the latest master to resolve minor merge conflicts and removed one commit as a dependency from this pull request. Originally I hoped for a quick merge, so I included a commit from #5092 to avoid merge conflicts.
Actually after excluding changes from https://github.com/heartcombo/devise/pull/5092 in this PR tests became inaccurate, so I had to apply the changes above.
@carlosantoniodasilva all checks have passed, no merge conflicts. Can you merge this?
