heap-ruby icon indicating copy to clipboard operation
heap-ruby copied to clipboard

Published 20 hours ago • verified publisher icon heap

Add support for idempotency_key and timestamp

Open macobo opened this issue 7 years ago • 3 comments

This continues work from https://github.com/heap/heap-ruby/pull/14 and also adds idempotency_key support.

macobo avatar Apr 18 '18 19:04 macobo

Coverage Status

Coverage remained the same at 100.0% when pulling 2fe3f82e98d388df1dae07b9aa389f610560b78b on macobo:timestamp-idempotency-key into 0f0a35389eb824e29c1ee099661eb3823653be42 on heap:master.

coveralls avatar Apr 18 '18 19:04 coveralls

I'm not sure about the failures here:

1.8 failure seems real, no support for this method, but others seem like things that would be failing on master as well.

Would it be worth dropping support for 1.8?

macobo avatar Apr 18 '18 20:04 macobo

<3

We could really use this as well :)

@drob @dorianj ? Think it would be possible to give one of us merge privileges?

jeffling avatar Apr 24 '18 13:04 jeffling