Heanh Sok
Heanh Sok
Closing as done.
Follow up from https://github.com/causify-ai/helpers/pull/262#issuecomment-2621616266 We encountered some formatting issues in the docstring of a function when the linter was run on the following file. This is non-blocking, as we can...
> That's a completely different error than before. Now it's failing because of some problem using the dockerized prettier. I'm guessing, it's because in https://github.com/causify-ai/helpers/pull/544 the default behavior of dev_scripts_helpers/documentation/lint_notes.py...
> @heanhsok do you know if your fix would also fix this? Yes it should as it looks like the same error.
### Global board > It would be good to have a GH board to see what everyone is working on > Maybe we can create an automation that adds every...
> 1. Do we need to pass GIT_ROOT through the container? We can do that, since I've extended the code to do that We use this variable to match the...
> set_path() > ERROR: Directory '' does not exist. I think the client code is missing the `.`, which points to the current dir https://github.com/causify-ai/helpers/blob/4868c54a4abf5a45ebef98dc7574422408e6bcf9/devops/docker_run/docker_setenv.sh#L37-L38
Closing as the problem no longer appears to occur. Follow-ups can be filed if needed.
> I think I will start by testing the docker_build_local_image (both single arch and multi-arch) since it's the first step in the docker release flow and covers many things. I...
Good test implementation overall ### Nits Just one small nit (apart from the unresolved comments in the PR https://github.com/causify-ai/helpers/pull/733/files). Can we make the tests directory-agnostic (i.e., so the tests can...