appium-roku-driver icon indicating copy to clipboard operation
appium-roku-driver copied to clipboard

feat(debug-log): create foundation of Roku debug log command

Open boneskull opened this issue 3 years ago • 2 comments

A Roku device has a debug log which is accessible via telnet. We can use this to provide data via the WD /session/:sessionId/log route.

What's here so far is an implementation of a thing which just listens on an arbitrary telnet server and pipes its output to a file, since that's probably unwise to keep in memory. When the command is issued, the driver can send the contents of the file to the client (and probably truncate it?).

This depends on type changes not yet published in Appium and will fail CI.

Note: The reason for two separate Telnet libs is that one provides a server & client and another only provides a client, but the client in the former is broken and I couldn't find another decent module which creates a dummy telnet server for testing.

UPDATE: This depends on https://github.com/appium/appium/pull/17640

boneskull avatar Oct 21 '22 00:10 boneskull

Current dependencies on/for this PR:

  • master
    • PR #6 Graphite
      • PR #7 Graphite
        • PR #8 Graphite 👈

This comment was auto-generated by Graphite.

boneskull avatar Oct 21 '22 00:10 boneskull

@jlipps what if the minimum node version was 16? 😜

boneskull avatar Nov 03 '22 01:11 boneskull