odeint-v2 icon indicating copy to clipboard operation
odeint-v2 copied to clipboard

Usage of Implementation details in lorenz-parameters.cu

Open DanielMueller1996 opened this issue 2 years ago • 0 comments

Hello, it came to light that in line 85 of the lorenz-parameters example https://github.com/headmyshoulder/odeint-v2/blob/db8b39ae27346e501941bf705362a1f4879b653c/examples/thrust/lorenz_parameters.cu#L70-L90 and in line 152 https://github.com/headmyshoulder/odeint-v2/blob/db8b39ae27346e501941bf705362a1f4879b653c/examples/thrust/lorenz_parameters.cu#L125-L162 implementation details of the thrust::make_zip_iterator are being used. Specifically this code should not work under the normal behavior of zip_iterators, as the shortest element in the iterator tuple is m_beta. This however still works because of how the implementation of thrust`s zip_iterator works. Specifically referencing the answer to this question https://stackoverflow.com/a/75212854/20624687 .

This should get fixed as people use this when learning about the capabilities of boost and thrust using this website: https://www.boost.org/doc/libs/1_81_0/libs/numeric/odeint/doc/html/boost_numeric_odeint/tutorial/using_cuda__or_openmp__tbb_______via_thrust.html

DanielMueller1996 avatar Jan 23 '23 17:01 DanielMueller1996