codebuilds
codebuilds copied to clipboard
headmelted
Fixes ARM vs x86 logic error & ChromeOS no longer has wget
There has always been a logic error when looking for an "ARM" processor.
If you have ARM it runs the x86 code and if you have x86 it runs the ARM code. BOTH fail.
ALSO since chromeOS 66 or 67 we've lost wget and we only have the "curl" command.
Both fixes are in this PR.
confirmed on a Samsung Chromebook Pro (with m5 process, which is 64_x86. essentially the Intel m5 is a slow intel i5 64bit x86 processor)
I'm on the dev channel which has chromeos 68.* but ever since chromeos 66 or 67 we lost wget.
Since this change is "Approved" what's the NEXT step to get it merged?
And It'll need the documentation changes in PR https://github.com/headmelted/codebuilds/pull/55 to make it fully compatible with chromebook (both x86 and ARM)
@headmelted My changes are because you have the logic BACKWARDS.
IF Arm Do x86 code else Do Arm Code
I completely understand Personal issues getting in the way. Everyone sounds so ROUGH and HEARTLESS in text (I certainly do) but that's is definitely not my intention.
You sounded absolutely fine don't worry 🙂. I've just not had any time to come back to this, but getting more time to bring it up to date now!
On Mon, Jul 23, 2018, 14:46 Damian Montero [email protected] wrote:
I completely understand Personal issues getting in the way. Everyone sounds so ROUGH and HEARTLESS in text (I certainly do) but that's is definitely not my intention.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/headmelted/codebuilds/pull/51#issuecomment-407063336, or mute the thread https://github.com/notifications/unsubscribe-auth/AKYVoOjEoWttD4Nkc8RcvOA5y2LREaGmks5uJdPGgaJpZM4Ugpg1 .
** BUMP ** @headmelted do you have any time for this PR? I see you've updated Visual studio to the latest. That's SUPER appreciated as I pointed someone with an ARM linux laptop to your amazing repo