headlamp icon indicating copy to clipboard operation
headlamp copied to clipboard

Published 20 hours ago • verified publisher icon headlamp-k8s

app: Add checkCommandConsent dialog for checking az/minikube/etc

Open illume opened this issue 1 month ago • 0 comments

  • Pops up a dialog asking the user if they consent to running the command.
  • Saves the choice and uses that choice in the future.

image

Related to

  • #1824
  • #1744

The General Settings part of issue #1744 is out of scope for this PR. That will be done in a future PR.

From a security standpoint, this adds an extra layer of protection for the user.

Now:

  • an attacker would need to change a plugin, AND the user settings to be able to run commands.

Before this PR:

  • they would just need to add something into a plugin.

Note: the running of commands is still disabled in main for now. Because we are not using that functionality yet. This PR does NOT enable the running of commands.

illume avatar May 28 '24 08:05 illume