headlamp icon indicating copy to clipboard operation
headlamp copied to clipboard

Add settings view

Open joaquimrocha opened this issue 4 years ago • 4 comments

There should be a settings view to allow the user to configre several aspects of the dashboard / clusters.

Acceptance Criteria:

  • [ ] There is a settings button and view available
  • [ ] At first, the settings should allow to see the details of all the clusters configured and change their accent color (#15)

Design:

TBD

joaquimrocha avatar Apr 02 '20 16:04 joaquimrocha

@joaquimrocha is there a design ready for this

ashu8912 avatar Oct 20 '20 07:10 ashu8912

Not yet.

joaquimrocha avatar Oct 20 '20 08:10 joaquimrocha

The design is close to finish.

joaquimrocha avatar Aug 11 '22 15:08 joaquimrocha

I had added a mockup here but turns out it needs some final touch.

joaquimrocha avatar Aug 26 '22 17:08 joaquimrocha

With github settings, I like how each section has it's own URL. So when you click on the sides or link to the settings from documentation or another part of the app it works.

What I don't like about github settings is you can't easily link to a section. Often there are many sections on a page, so you need to scroll down a lot. For example, if you click on the "Appearance" sidebar menu, and scroll down you see "Emoji skin tone preference". Would be better if there was an anchor on that section so people could link to it.

image

Search box? Settings like Edge (and firefox, etc) have a settings view that allows you to search within the different settings options.

image

illume avatar Oct 17 '22 11:10 illume

I think we can take "inspiration" from vscode for the way it handles settings for plugins, it allows plugins to have their own settings in a separate subsection.

image

yolossn avatar Oct 18 '22 10:10 yolossn

Here is the latest design we have from @tsompura: Settings design image

Also, about the search, I think it makes sense when we have more than a few options, i.e. more than one "page" of settings. This will likely happen in the future, but as an MVP for settings, I don't think search is needed.

joaquimrocha avatar Oct 18 '22 13:10 joaquimrocha

I think we can take "inspiration" from vscode for the way it handles settings for plugins, it allows plugins to have their own settings in a separate subsection.

I really like the idea of having plugins being able to add their own settings if they want. But I wonder if anyone needs that already?

For bundled plugins, they should probably not be listed under a plugins section? Because they are part of the app, and not plugins from the perspective of the users and the developers of those apps.

illume avatar Oct 19 '22 08:10 illume

Screenshot 2022-12-23 at 12 44 02 PM

ashu8912 avatar Dec 23 '22 07:12 ashu8912

Adding the points from our discussion.

  1. In In-cluster mode it is import to make the message correct that the settings are specific to the user and not something a admin can set for the whole application. Like setting the language to french for example and expecting it to be the default for all users.
  2. In In-cluster mode if the user sets the settings in a browser and accesses headlamp from another device or browser the settings will be completely different.

yolossn avatar Dec 28 '22 14:12 yolossn