headlamp icon indicating copy to clipboard operation
headlamp copied to clipboard

plugin: Add plugin compatibility check UI

Open illume opened this issue 1 year ago • 3 comments

For https://github.com/headlamp-k8s/headlamp/issues/423#issuecomment-1831672945

  • frontend: App: Move <Plugins> into AppContainer for snackbars
  • frontend: plugin: Add warning snack about incompat plugins
  • frontend: Fix npm run i18n to include missed files

Screenshot 2023-11-30 151934

How to test?

Get an old plugin with headlamp-plugin < 0.8.0.

git checkout v0.20.0
cp -a plugins/examples/pod-counter plugins/examples/pod-counter-old
git checkout -
cd plugins/examples/pod-counter-old
npm install
npm start

test the app has a settings plugin link

cd app
npm install
npm start

You should see the snackbar message with a link to the plugin settings.

In the frontend (not in app mode)

There should be no link to plugin settings on the snackbar warning.

illume avatar Nov 30 '23 14:11 illume

I still see the plugin as being enabled after I get the incompatible notice.

joaquimrocha avatar Jan 11 '24 09:01 joaquimrocha

@illume , if you prefer we can merge this and deal with disabling the plugin in a separate PR. But the current UX is a bit confusing as we're told the plugin is incompatible but it still looks like it's loaded/running.

joaquimrocha avatar Jan 11 '24 09:01 joaquimrocha

@joaquimrocha Yeah, I can fix the settings view in this PR.

illume avatar Jan 11 '24 10:01 illume

Thanks @knrt10 I updated that type, and added those translations.

illume avatar Mar 04 '24 17:03 illume

I am seeing the same as previously commented, although not sure if the links are meant to be clickable as for me they aren't.

image

the plugins settings page looks to be up to speed! LGTM image

vyncent-t avatar Mar 04 '24 19:03 vyncent-t

Thanks @vyncent-t

Here's the action notifier now.

image


Here is the plugin settings screen in app mode.

image


Here it is NOT in app-mode.

image

illume avatar Mar 04 '24 20:03 illume

Just reviewed the changes, color is now dark, enable is on app mode, enable not on web!

vyncent-t avatar Mar 04 '24 20:03 vyncent-t