Charles Oliver Nutter

Results 1052 comments of Charles Oliver Nutter

FWIW I have to say this is one of the more unusual pieces of code I've run into, and it seems really fragile: ```ruby def response_tagged TaggedResponse.new(tag, *(SP!; resp_cond_state), @str)...

The code should work, don't get me wrong. We will have a fix in JRuby shortly. The problem with that code, though, is that it is non-obvious that there's state...

FWIW since you are actively working on this library, I'm happy to continue collaborating on improvements! I may step back for a day or two due to some upcoming releases...

@nevans You probably just installed the regular `prism` parser gem. We can use that, but as an external library for tools needing a parser. In order to install Prism for...

Hmm doesn't seem like it should be difficult to implement.

Just a note, async-profiler has this feature and it seems to work well there. I am not sure whether it is something they do in the native binding or if...

It looks like all the linked PRs have been merged. Is this done? Is there a way to get a prerelease gem pushed for testing, or JRuby added to CI?

@Morriar Ok thank you for that update! In #2433 I noticed there are still a number of places that the `ruby.h` file and friends are required. I'm not sure if...

Thank you! Fix should be fairly simple, just use JDK sleep methods that have nanosecond precision and track time spent in nanoseconds.

Doesn't appear any specs were written for this when it was fixed in TR so we should add some.