Charles Oliver Nutter

Results 1067 comments of Charles Oliver Nutter

Hey checking back in after a long time. I'd like to help get this green... have you looked into the failures at all?

It looks like this currently falls back to the pure-Ruby version only if the extension (JRuby or CRuby) does not load: https://github.com/ruby/racc/blob/2c5a142f03ecde2044767d8d51eb05547777881f/lib/racc/parser.rb#L189-L214 I think we would need some additional code...

> JRuby and TruffleRuby could optimize it for the JVM I don't see how we'd be able to optimize it for the JVM if it is imported as a C...

This does not pass tests because the tests expect that `eval "__LINE__", b` will use the line number from binding `b` but that behavior no longer matches Ruby (CRuby 3.0+...

> expect per-version? 😕 @stdedos Perhaps, or maybe this gem should just ditch support for really old Ruby versions that behave differently?

> it's already too much if the maintainer "abandoned" the gem Yes, it seems a bit quiet. Feel free to ping me if I'm needed again!

> Idk if @headius has tests figured out I have not looked at the tests other than to confirm that they pass the same with the JRuby extension code removed...

> It seems like we may need to just hardcode the line numbers that are correct now Agree. 👍

Could this be something that changed in YAML 1.2? The Psych extension for JRuby moved to a newer version of SnakeYAML (SnakeYAML Engine) that is now YAML 1.2 compliant.

I finally dug back to this in my inbox and could help land it... what needs to be done at this point?