Charles Oliver Nutter

Results 1104 comments of Charles Oliver Nutter

GC.compact is added but does nothing (we do not have that level of control over JVM GCs).

The optimized Array#minmax and Range#minmax would be pretty easy Java tasks for someone. They could be pure-Ruby, but that would not really gain us much over just using Enumerable#minmax. Array#minmax...

Comparable#clamp is there but does not appear to support endless or beginless ranges.

Updated based on current master.

I think we can call this one done. The implementation improvements might be interesting for the performance work planned in 9.5, but we have implemented basically everything else in this...

See https://bugs.ruby-lang.org/issues/18516 for some recent changes in this area.

Did it fix the issue?

Latest runs appear to be green, so I'm optimistically closing this.

@marcandre Oops, I must have been looking at an old build or a different branch. Will investigate a bit locally.

One failure on 9.3: ``` 1) RuboCop::AST::RegexpNode#to_regexp with a regexp with an "n" option is expected to eq "/abc/n" Failure/Error: it { expect(regexp_node.to_regexp.inspect).to eq('/abc/n') } expected: "/abc/n" got: "/abc/" (compared...