Charles Oliver Nutter

Results 1431 comments of Charles Oliver Nutter

I'll have a look at the Input failures soon.

I suppose that's what I get for not getting tests running before making changes. Here's the patch for JRuby::Rack::Input: ```diff diff --git a/src/main/java/org/jruby/rack/ext/Input.java b/src/main/java/org/jruby/rack/ext/Input.java index e680e79..2cdd8e3 100644 --- a/src/main/java/org/jruby/rack/ext/Input.java +++...

@jlahtinen The patch above should work properly... I botched it before 🤦.

@chadlwilson I merged that fix to master so if you rebase you'll pick it up.

I believe we can set up our entities to register themselves, correct? I played with part of this but perhaps did not register it early enough.

I understand what you are doing here but I want to figure out how to get the JPA subsystem to see our entity classes as defined. > Hibernate only “sees”...

@mguymon You still out there? I'd like to collab to merge the functionality of your `lock_jar` with the actively-maintained `jar-dependencies` we ship with JRuby... https://github.com/jruby/jar-dependencies

@mguymon Thanks for helping out here! It's probably still a good idea for us to either merge efforts or direct JRuby users toward jar_dependencies, but I could be convinced that...

> previously fixed by https://github.com/jruby/jruby-rack/pull/212 in 1.2.21 I assume you mean 1.1.21? Could you put together a new PR based on #212 that applies it to master? Alternatively we could...

We can also release a 1.1.x release now that the fix for #247 has been fixed there as well, if we want a smaller target for the moment.