Charles Oliver Nutter
Charles Oliver Nutter
False alarm on that verbose output... running the jruby-launcher install again does NOT output the verbose build stuff. It may be something to do with the old launcher not setting...
@mrnoname1000 I see there are some failures to find the jruby.sh file now that tests are running. Other failures are possibly behavior changes in jruby.sh that were never reflected in...
@mrnoname1000 I believe they are all tests that live in this repository. Have a look at the failed jobs (and I will as well).
Looks like a number of these are failing because the test harness expects some native launcher-only debug flags to be used: ``` 38) JRuby native launcher should use --module-path on...
Aha... and many of them expect to be able to run the launcher in the absence of JRuby! Obviously that won't work when it has to have the shell script....
Yeah we will need to fully reexamine these specs... I'm not sure any of them are valid or supportable directly with the new code. I'm still figuring out where all...
FWIW I ran some of our larger JRuby test suites with this new launcher and saw no failures related to the command line.
I have pushed this version as a preview gem, jruby-launcher 2.0.0.pr1, installable by `gem install --pre jruby-launcher`. It seems to work just fine for me.
This patch excludes the specs when not running on Windows. No specs run, but none of them are really valid with the skinny launcher anyway. ```diff diff --git a/spec/launcher_spec.rb b/spec/launcher_spec.rb...
@Earlopain Thanks for the report! Can you confirm that the file it claims is missing exists? It really *should* be there.