Charles Oliver Nutter

Results 1052 comments of Charles Oliver Nutter

I wonder how far off the 71.x versions are from working on 7.2 and 8.0. We know we need to catch up! The jump from 7.0 to 7.1 was surprisingly...

Thanks for the patience and help everyone. I'm thinking it would be best for us to concentrate on Rails 8 support as much as possible given available resources, but I...

Why is this extra logic needed compared to the standard version? https://github.com/rails/rails/blob/82e9029bbf63a33b69f007927979c5564a6afe9e/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L283-L295

Wow, and here I was hoping we found some magical way to marshal a binding. Should be an easy fix.

A bit trickier than it seems at first. CRuby apparently just represents `Binding` using the old `T_DATA` struct internally, which can only be marshaled if it defines a `_dump_data` method....

Relevant code in CRuby: https://github.com/ruby/ruby/blob/1e3d24a0f47e142270bfb6073feb77f6364af052/marshal.c#L1081-L1094

Aha, we added such a marker interface 16 years ago. 😆 https://github.com/jruby/jruby/blob/1bbd1a42075a6ae9a81c80113d085ea0f00f5f58/core/src/main/java/org/jruby/runtime/marshal/DataType.java

These errors do not seem to be related to aarch64, even though they may only be appearing on that platform. The two errors you provided are in the JRuby launcher...

I can reproduce both errors locally by simply pointing a `ruby` command (JRuby or CRuby) at the launcher executable. The first example is using the sh script and the second...