hdmf icon indicating copy to clipboard operation
hdmf copied to clipboard

Modification to Fix conversion of Zarr string dataset to HDF5

Open rly opened this issue 1 year ago • 1 comments

Proposed changes to #1171.

It would be nice if HDF5IO and the ObjectMapper can accept any Zarr array just like it accepts any Numpy array, instead of accepting only Zarr arrays that have been written with hdmf-zarr.

rly avatar Aug 20 '24 08:08 rly

Codecov Report

:x: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 88.67%. Comparing base (2b90d21) to head (deec517). :warning: Report is 1 commits behind head on fix/zarr_str_export.

Files with missing lines Patch % Lines
src/hdmf/build/objectmapper.py 18.75% 11 Missing and 2 partials :warning:
src/hdmf/utils.py 57.14% 2 Missing and 1 partial :warning:
src/hdmf/backends/hdf5/h5tools.py 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@                   Coverage Diff                   @@
##           fix/zarr_str_export    #1175      +/-   ##
=======================================================
- Coverage                88.83%   88.67%   -0.16%     
=======================================================
  Files                       45       45              
  Lines                     9841     9855      +14     
  Branches                  2798     2802       +4     
=======================================================
- Hits                      8742     8739       -3     
- Misses                     779      794      +15     
- Partials                   320      322       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 20 '24 08:08 codecov[bot]

Tests are failing because the base PR is too out of date. I will merge and we can review in the base PR.

rly avatar Oct 31 '25 18:10 rly