Harry Garrood
Harry Garrood
This is very difficult to review as-is because of its size. Can you please break this up into smaller PRs which address individual points? Also can you please back out...
I would rather have more code to review overall if that allows making changes incrementally; I don't want to do a full rewrite. Most of the individual changes you've listed...
Here's another use case for allowing users of this library to respond to control characters: purescript/purescript#934. I wonder if a better API would be to add a function which can...
Just to set expectations: I think a PR for this is unlikely to be merged. If we are going to address this, we should probably do so via a general-purpose...
It's mostly that I think the behaviour should be uniform across everything we inline (see Language.PureScript.CoreImp.Optimizer.Inliner). I guess if this can be sensibly done without building in special casing for...
Yes, definitely. That page is only like that because it predates psc-package.
If the purpose of the guide is to present a sensible workflow for purescript without node, then psc-package is definitely the right choice. We could certainly do with more docs...
Yes: https://github.com/purescript/purescript-typelevel-prelude/blob/v1.0.0/src/Type/Data/Ordering.purs#L18-L18 I'm not sure the FFI page is the right place for it, though; I don't think it really has anything to do with the FFI (in fact I...
I'm using Sphinx for my guide to the purescript numeric hierarchy and I'm really impressed with it. Also ReadTheDocs makes hosting dead simple, even easier than GH pages imo. The...
That looks like a good starting point to me, but it seems we're now starting to talk about a fairly fundamental reorganization of the docs in addition to just switching...