Henry de Valence

Results 259 comments of Henry de Valence

Dropping the logging module we have now and replacing it with `tracing` solves the configurable-log-level problem for free.

Changed labels because `planning` should be for planning tasks not involving code changes (closed when the plan is made / question is resolved / etc) and `refactor` should be for...

note also: because the `NodeTable` maintains `BTreeSet`s for `by_score`, `by_time`, but the custom-ordering-tuple-newtypes don't hold borrows, all of the node data is held in triplicate

aha, we may not be able just to simplify the comparison functions, because the code that maintains the data in triplicate stops working if we relax requirements on the sort-by-x...

On little-endian machines, you can use a pointer cast to convert a `&mut [u8; 200]` into a `&mut [u64; 25]` for free. You may have to byte-swap on big-endian machines,...

One idea worth looking at is the following. As far as I know, the JubJub implementation in Sapling has functions (like point addition) that take as parameters the point operands,...

Eventually we want to have `impl From for EdwardsPoint` and `impl Into for EdwardsPoint` (ie define a serialization format) but for the moment, to do testing, we could add a...

Yes, I think we'll need to implement the scalar field. I'm not sure what the modulus is, we should probably get a hold of the sage script @ebfull used and...

Hi! The `curve25519-dalek` source code the `field.rs` implementation is copied from has an implementation of inversion using a hardcoded addition chain; we were planning to use that implementation, but we...

I'll do this this afternoon; I think it would be good to rework the field arithmetic a little bit. The reason is that the scalar arithmetic in curve25519-dalek is one...