Dan Dumont

Results 44 comments of Dan Dumont

Also... I am getting unsafe access warnings when trying to access the innards of this Variant, like when I need to check the value of something inside. The compiler tells...

I would prefer a simpler approach, similar to the rocket shutdown signal. That way the application author can decide where the certs are coming from easily, and outside the context...

I thought about it some more, and it made sense to me to have rocket manage an impl of the resolver. #2748

One approach I tried first was to implement a wrapper around FileServer and implement a Handler that would defer to FileServer and adjust headers on the way out. I could...

Hashing the files would be nice for other reasons, like you say, but it would also introduce performance overhead. I think that's best left to another PR to implement features...

@ApprenticeofEnder Is this something that the Rocket team would like to merge? How do I proceed here?

@SergioBenitez Is this something that the Rocket team would like to merge? How do I proceed here?

Some comments about your proposals: I think I can come up with something that doesn't change NamedFile, though I do think there will be some duplication of code, because the...

@SergioBenitez I removed changes to NamedFile which should address (1) See my response above for (2) and (3)