astpath recent upgrade breaks `bellybutton lint`

[nanorepublica]

Hi

One of your dependencies astpath upgraded on Friday and removed an argument return_lines from find_in_ast function call.

The lines concerned are https://github.com/hchasestevens/bellybutton/blob/master/bellybutton/linting.py#L57

and

https://github.com/hchasestevens/bellybutton/blob/master/bellybutton/parsing.py#L137

a simple fix would be to fix the version of astpath until a full change can be made.

Thanks

[hchasestevens]

Hi @nanorepublica , thanks for bringing this to my attention. I've pegged the version of astpath used to 0.6.1. Can you please confirm that this has fixed the issue temporarily?

[mozz100]

Hi @hchasestevens and thanks for the quick response on this. I work with @nanorepublica and we have just confirmed that updating to bellybutton 0.2.4 gets things working again.

Regards

Richard

[hchasestevens]

@mozz100 Thanks for confirming. I'll look to release a proper fix soon. Apologies for any inconvenience.

[moagstar]

Thanks for this great little tool! It would be nice to get a proper fix for this, I would like to use the regular expression functionality in a bellybutton rule. If you have an idea of what is needed to fix this properly I would be happy to help out.