hcengineering
DRY and visibility icon + reminder order bug fixes for Create/Edit Event modal
Pull Request Requirements:
- Provide a brief description of the changeset.
- Include a screenshots if applicable
- Ensure that the changeset adheres to the DCO guidelines.
-
CreateEvent.svelteandEditEvent.sveltehad highly similar structure and functionality that could be condensed into a single component to ensure DRY (Don't Repeat Yourself) principles. -
Previously, the visibility icon on the modal would always be "Hidden" regardless of what the actual visibility was. This has been changed to be synchronized with the selected visibility's icon.
-
Previously, reminders would be added to the modal in whatever order they were selected in, leading to an odd structure such as:
- 15 minutes before
- 1 day before
- 1 hour before
- 10 minutes before
This has been corrected to display the reminders in order and handles both editing and adding a reminder. Reminders that have already selected also no longer show up in the options for adding a new reminder or editing an existing reminder.
Hello @Armandoraf! Thanks for the contribution. DRY is good, but there are several things that I don't like:
- Naming. I would prefer EventContent rather than EventManager name for the component.
- Lots of bound values, can we do something with that?
One more think, if your PR contains fixes for different issues, not related to each other, it is better to open separate pull requests for them.
