platform icon indicating copy to clipboard operation
platform copied to clipboard

Private project is displayed in list of all projects

Open aonnikov opened this issue 1 year ago • 6 comments

I see a private projects that I should not have access to in list of all projects. The project is private and I’m not in the list of members. See screenshot:

Huly®: UBERF-6271

aonnikov avatar Apr 02 '24 09:04 aonnikov

Hey I am new to open source, I'm interested in learning and contributing to this repository. Could I try working on this issue?

SuneethJerri avatar Apr 04 '24 19:04 SuneethJerri

You can try if you are able to reproduce the issue, but I'm afraid, it can be a bit difficult. We have several issue marked with good first issue label, try to start with them first.

aonnikov avatar Apr 05 '24 06:04 aonnikov

I successfully reproduced the problem and managed to hide the project names marked as private. Could you please direct me to the specific component responsible for displaying the project list?

SuneethJerri avatar Apr 05 '24 06:04 SuneethJerri

The issue has nothing todo with any component. Visibility of objects in the platform is controlled by space security at query level. Security middleware is located here: https://github.com/hcengineering/platform/blob/main/server/middleware/src/spaceSecurity.ts

aonnikov avatar Apr 05 '24 06:04 aonnikov

Denis Bykhov does guest user changes fix this problem?

aonnikov avatar May 07 '24 16:05 aonnikov

Yes it will be fixed in Guest PR

BykhovDenis avatar May 07 '24 18:05 BykhovDenis