platform icon indicating copy to clipboard operation
platform copied to clipboard

added email validation for signUp users in Platform

Open haykeminyan opened this issue 1 year ago • 5 comments

Users previously could use fake non-email fields like 123, 321 e.t.c

Example curl:

curl --location 'https://account.bold.ru/' \
--header 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:123.0) Gecko/20100101 Firefox/123.0' \
--header 'Accept: */*' \
--header 'Accept-Language: en' \
--header 'Accept-Encoding: gzip, deflate, br' \
--header 'Referer: https://app.bold.ru/' \
--header 'Content-Type: application/json' \
--header 'Origin: https://app.bold.ru' \
--header 'Connection: keep-alive' \
--header 'Sec-Fetch-Dest: empty' \
--header 'Sec-Fetch-Mode: cors' \
--header 'Sec-Fetch-Site: same-site' \
--header 'Sec-GPC: 1' \
--header 'TE: trailers' \
--data '{"method":"createAccount","params":["1234","4343","test","test"]}'

now added from Svelte dev validation for email link [https://svelte.dev/repl/54d159b954d9412c8247807125d9fe1b?version=3.12.1]

haykeminyan avatar Feb 14 '24 20:02 haykeminyan

Thanks for a contribution, could you please add sign off and gpg signature. Thanks.

haiodo avatar Feb 15 '24 06:02 haiodo

Thanks for a contribution, could you please add sign off and gpg signature. Thanks.

thanks! have used this link for adding GPG and Sign-Off. Checked with git log --show-signature seems now is a good.

haykeminyan avatar Feb 15 '24 18:02 haykeminyan

Hi, you need to signoff and sign all commits, please use following git command to do so.

git rebase --exec 'git commit --amend --no-edit -n -s -S' origin/main

haiodo avatar Feb 15 '24 19:02 haiodo

git rebase --exec 'git commit --amend --no-edit -n -s -S' origin/main

I have tried but seems failing. ❯ git rebase --exec 'git commit --amend --no-edit -n -s -S' origin/main Executing: git commit --amend --no-edit -n -s -S error: gpg failed to sign the data fatal: failed to write commit object warning: execution failed: git commit --amend --no-edit -n -s -S You can fix the problem, and then run

git rebase --continue

After executing command with --continue get:

git rebase --continue Executing: git commit --amend --no-edit -n -s -S interactive rebase in progress; onto 715193957 Last commands done (4 commands done): pick aad6fc42a added email validation # empty exec git commit --amend --no-edit -n -s -S (see more in file .git/rebase-merge/done) No commands remaining. You are currently editing a commit during a rebase.

No changes You asked to amend the most recent commit, but doing so would make it empty. You can repeat your command with --allow-empty, or you can remove the commit entirely with "git reset HEAD^". warning: execution failed: git commit --amend --no-edit -n -s -S You can fix the problem, and then run

git rebase --continue

haykeminyan avatar Feb 15 '24 19:02 haykeminyan

git rebase --exec 'git commit --amend --no-edit -n -s -S' origin/main

I have tried but seems failing. ❯ git rebase --exec 'git commit --amend --no-edit -n -s -S' origin/main Executing: git commit --amend --no-edit -n -s -S error: gpg failed to sign the data fatal: failed to write commit object warning: execution failed: git commit --amend --no-edit -n -s -S You can fix the problem, and then run

git rebase --continue

After executing command with --continue get:

git rebase --continue Executing: git commit --amend --no-edit -n -s -S interactive rebase in progress; onto 7151939 Last commands done (4 commands done): pick aad6fc42a added email validation # empty exec git commit --amend --no-edit -n -s -S (see more in file .git/rebase-merge/done) No commands remaining. You are currently editing a commit during a rebase.

No changes You asked to amend the most recent commit, but doing so would make it empty. You can repeat your command with --allow-empty, or you can remove the commit entirely with "git reset HEAD^". warning: execution failed: git commit --amend --no-edit -n -s -S You can fix the problem, and then run

git rebase --continue

I have dropped previous commits and now contains only 1 signed commit. Is it good now?)

haykeminyan avatar Feb 15 '24 19:02 haykeminyan