Howard Bushouse

Results 116 comments of Howard Bushouse

What/where are the invalid docs links and what effect are they having?

> Looks good. I'm just wondering if we need a regression test given that this is not run in the pipeline. That would be good, because by default it's not...

The CI failures appear to be unrelated and caused by some test data files not being included in the PR branch (such that tests can't find the inputs/outputs they need).

I'm going to merge this now, so that we can have it included in our next B9.0 release candidate. It's not necessary for use in the operations pipeline, but that...

A regression test can be added later in a separate PR.

Looks like lots of unit tests need updating (lots of failures in all CI tests)

This is another one of those little details who's reasons are lost to the mists of time (at least it's pretty misty in *my* mind). I recall at least one...

But, but, but ... here in the resample step it sure looks to me like pixels flagged with REFERENCE_PIXEL are set to be rejected: https://github.com/spacetelescope/jwst/blob/master/jwst/resample/resample.py#L284 Is this somehow not working...

But at the same time the top level `resample_step` module has https://github.com/spacetelescope/jwst/blob/master/jwst/resample/resample_step.py#L20 which does not pay attention to REFERENCE_PIXEL and gets stored in the `kwargs` passed around to lower-level routines:...

I'm assuming that there's no real benefit in running a regtest against the PR branch, because the new stuff is turned off by default, hence we don't expect the new...