Holger Brunn
Holger Brunn
/ocabot merge minor
@sbidoul looks like you have to rewrite this to use savepoints?
@ivantodorovich > I'm not sure I see the value for this module anymore in 17.0 🤔 What's the point, being that you can do the same with the core `email_layout_xmlid`...
tests are fixed in https://github.com/OCA/server-tools/pull/3271
another discussion point: Given that basically all modules that mess with sms at all override sms.api#_send_sms_batch and/or sms.sms#_postprocess_iap_sent_sms, it's crucial that the overrides of sms_alternative_provider come after any other override....
sms_ovh_http works in both cases, so that's not a good example. sms_masked_content would have a problem, but that's handled accidentally right because modules on the same level (=same dependencies, both...
ja hmm, i didn't think this through: at the point we can patch something, a module that we want to depend on ours might already be loaded, meaning its overrides...
@thomaspaulb since https://github.com/OCA/OCB/commit/851f83fc5d6cbd70d5b801ceed54b46d38874afb the tests need another patch to succeed. Then the sms_ovh_http code only succeeds because it creates its own sms account, if that doesn't exist we run into...
@thomaspaulb you shouldn't be doing this manually, if you had waited for https://github.com/OCA/repo-maintainer-conf/pull/113 to be merged, ocabot would have done it automatically
just rerun copier, then you should be fine