Holger Brands

Results 161 comments of Holger Brands

Currently the ListEvent-API mixes methods for handling blocks and individual changes per index. I think the block handling API needs to be able to provide multiple old values per block...

Just to demonstrate with Robs example and the current API methods: ```java interface ListEvent { BatchedListEvent asBatch(); boolean next(); int getIndex(); int getType(); E getOldValue(); ... other individual processing methods...

Note that when we add icons, we'll also need to add a Listener for the Table. This is so that when the SortedList's Comparator is changed externally, we can remove...

GH-383 has been marked as a duplicate of this issue. *** by jessewilson

From kennethorr: Adding the following lines to the widgetSelected(SelectionEvent e) method would solve this: int sortDirection = comparator.isColumnReverse(columnIndex) ? SWT.DOWN : SWT.UP; table.setSortColumn(column); table.setSortDirection(sortDirection); by jessewilson

Currently, SWT table only supports one sort column natively. So, with single column sorting we are fine. But what to do, when multi column sorting is used? a) do nothing...

I think we wanna go for the best user experience. C is best, with B as a reasonable fallback! by jessewilson

For now, I implemented sort-indication using sort column and sort direction of SWT table itself (Table.setSortColumn(...), Table.setSortDirection(...)). As a consequence, I implemented option (b) for multicolumn sort. by brands

@tcrass Thanks for reporting this "misbehavior". Looking at the code, I suspect this has never worked correctly. Currently, it only makes sense to use strict mode with STARTS_WITH. Do you...

Please have a look at the implementation: EventSelectionModel/DefaultEventSelectionModel delegates a lot of work to the class ListSelection. ListSelection manages a few event lists which are dependent upon the source list....