Hwee-Boon Yar
Hwee-Boon Yar
Done. Details in this issue. Thanks Justin.
Explorations totally fine. But remember we have other more urgent things to do :)
Yeah, daily improvements are the best. Good for you!
> How different is this from #3990 ? #3990 is about extracting logic from real coordinators This (#4282) is about renaming misnamed coordinators to something more appropriate eg. #4283. In...
@eviltofu similar to https://github.com/AlphaWallet/alpha-wallet-ios/issues/3990#issuecomment-1132479898, make a list of checkboxes here.
> `AnalyticsCoordinator` does not inherit from `Coordinator` but is a protocol. `AnalyticsCoordinator` should be renamed `Analytics` and concrete implementations should be named `AnalyticsService`. Yes, but `Analytics` and `MixpanelAnalytics`.
> `UniversalLinkCoordinator` does not inherit from `Coordinator` but from `UniversalLinkCoordinatorType`. Not coordinator, so maybe `UniversalLinkHandler`? But let's not call everything "handlers" (or managers!). Just seems appropriate for this one case.
Looking… Strange that it says it's a regression from v3.40 (427) and was closed. I checked the closed issues and it's not there.
> @hboon does it means that we trying to store single string that is larger then 16mb? Seems so according to https://www.mongodb.com/docs/realm-legacy/docs/swift/latest/#current-limitations > Data and String properties cannot hold data...