SparkleShare
SparkleShare copied to clipboard
hbons
Fix/windows build
Based on pull-request of etinin Changed to the same git as the MacOS version uses. Changed to use Windows native OpenSSH. The requirements are checked and automatically downloaded as a post build step.
Thanks for this. Most of this looks good, but I cannot except downloads from sources that are not vetted like these:
# in SparkleShare/Windows/postBuild.cmd
https://github.com/senthilrajasek/tartool/releases/download/1.0.0/TarTool.zip
# in SparkleShare/Windows/sha256.cmd
https://github.com/npocmaka/batch.scripts/blob/master/fileUtils/sha256.bat
Is it possible to do this in a different way?
Its almost a year since request, i cant exactly remember the reasons. TarTool maybe could be exchanged to Windows 10 tar.exe, which is now part of windows. Not sure if it also was a year ago. The sha256.bat script is taken from https://github.com/npocmaka/batch.scripts/blob/master/fileUtils/sha256.bat, which should be legal with the link reference in it. Found no other way to verify a file sha256 with windows.
if "git-bash" for windows is installed (which is quite a well known
package) - then you can use the command sha256sum. I'm almost sure it
also has tar (and many other Linux tools).
Download:
https://git-scm.com/download/win
For other OS's:
https://git-scm.com/downloads
On Fri, May 21, 2021 at 2:05 PM uenz @.***> wrote:
Its almost a year since request, i cant exactly remember the reasons. TarTool maybe could be exchanged to Windows 10 tar.exe, which is now part of windows. Not sure if it also was a year ago. The sha256.bat script is taken from https://github.com/npocmaka/batch.scripts/blob/master/fileUtils/sha256.bat , which should be legal with the link reference in it. Found no other way to verify a file sha256 with windows.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hbons/SparkleShare/pull/1947#issuecomment-845872142, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6NCKZFAMNCLF5E7Y7WYXLTOY46PANCNFSM4OKFUEEQ .
I´m aware of git-scm. But that can lead to a path dependency of the buildscript. I can easily eliminate TarToool.exe from the postBuild script by using the windows tar.exe. But i cant see your point about sha256.cmd. Its no external dependency dependency and due to the MIT license it should also be legally ok. And it does its job out of the box.
Thanks for the update. It's not really a legal issue, it's just that the sha256 bash script can easily be changed by someone else to run whatever they want.
Yes that’s clear, therefore the script is part of the patch. The reference in it is only for information. So only the person who clones the repo can change it. When using an other md5 tool this person could also edit the post build script with the same effect.
It were nice if the windows version could be updated. Thank you to all of you for your efforts!
@hbons Now i think the job for a possible windows version is done. If you don't want the merge all these changes, which I could well understand, i would like to "publish" an unofficial windows build on my fork page so that other could profit from my effort. But only if that is ok for you, because it is your project.
@hbons - do you have any objection to the @uenz's fork or do you prefer to merge?
@uenz - thank you for the so much awaited update to the Windows front-end. Is there any CI pipeline in your fork that builds the Windows install packages automatically? Here is an example of such CI and here are the artifacts.
@AvtechScientific At the moment not. I don´t think that it is that easy because of the gui. I´l have a look. If you can´t wait for @hbons answer you can download the scoure code and build it for yourself. Steps to do are here.
@AvtechScientific At the moment not. I don´t think that it is that easy because of the gui. I´l have a look. If you can´t wait for @hbons answer you can download the scoure code and build it for yourself. Steps to do are here.
Also the example I have provided has gui. I actually assume it will be easier in the SparkleShare case. Probably this .NET docker image can help. Or maybe .NET and Wix in one image.
Hi @hbons!
We are a charity where needy people are provided with occupation of digitizing ancient books. We use git as our repository. Since most editors are non-tech-savvy Windows user - we heavily rely on SparkleShare's (old) Windows frontend (which has several acute problems). May I ask you to update/merge it, please?... Thank you for your great tool!
Hi @hbons, thanks to the hintsof @AvtechScientific i´ve a working travis-ci for the windows build. At the moment im struggling a bit with the upload of the build results to github as "nightly build". A update will follow the next days.
Hi @hbons, thanks to the hintsof @AvtechScientific i´ve a working travis-ci for the windows build. At the moment im struggling a bit with the upload of the build results to github as "nightly build". A update will follow the next days.
That's a great news! Waited for it for years! Thank you!
@uenz: could you, please check and confirm that your SparkleShare-windows-nightly.msi can clone a new project? I was not able to clone my SparkleShare fork on GitHub. However I must admit that it could be due to me messing around with the old and new installation and the Windows' AppData folder... Thank you for the great PR!