CountryCodePickerProject
CountryCodePickerProject copied to clipboard
hbb20
Country list dialog window is having much space in left & right.
When you click the ccp to select country , a dialog appears that would has country lists , Right ?
Then if we check the same with small size devices , the country name list are not properly aligned and positioned as well. there is an overlap between two item if it was in small screen device.
Sorry about that. Can you share the screenshot that will give me better idea where to look to fix.
On Thu, Aug 6, 2020 at 12:23 Gopinatha [email protected] wrote:
When you click the ccp to select country , a dialog appears that would has country lists , Right ? Then if we check the same with small size devices , the country name list are not properly aligned and positioned as well. there is an overlap between two item if it was in small screen device.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hbb20/CountryCodePickerProject/issues/431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFQ32EL2UFSXMLLFZJSPS3R7LYKNANCNFSM4PW3IUHA .
No problem . Thanks much for addressing this quickly. I had checked it in one plus . Have a look at it .https://pasteboard.co/JlcZI0J.jpg
I see. Margin on side is because standard dialog in android keeps that space. And for row, the one you highlighted takes two lines and that's why it's bigger than others. I guess it should not overlap though because recycler view handles height calculation.
Yes. I agree with you. I'm justing few things here ,
- we can provide an option either dialog style or normal view, just presenting on top of parent (being presented)
- if we consider point 1, margin also taken care.
- We can provide close button/ dismiss it when user press outside (presented as a normal view - in that case point 3 is considerable). Let me know your thoughts on this !