hazelcast-python-client icon indicating copy to clipboard operation
hazelcast-python-client copied to clipboard

Add put_all() to MultiMap [API-1235]

Open nevzatseferoglu opened this issue 2 years ago • 3 comments

Corresponded Java Client PutAll method: https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/multimap/MultiMap.java#L81

ListDataCodec was missing. It was required to run client binary protocol codec generator properly. Ported from java. https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/client/impl/protocol/codec/builtin/ListDataCodec.java#L25

There had to be a change in protocol repository as well. https://github.com/hazelcast/hazelcast-client-protocol/pull/432

nevzatseferoglu avatar Sep 12 '22 05:09 nevzatseferoglu

Codecov Report

Merging #573 (a5d1151) into master (3feb0c2) will decrease coverage by 0.01%. The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   96.44%   96.43%   -0.02%     
==========================================
  Files         355      356       +1     
  Lines       20208    20259      +51     
==========================================
+ Hits        19489    19536      +47     
- Misses        719      723       +4     
Impacted Files Coverage Δ
hazelcast/protocol/builtin.py 94.35% <85.71%> (-0.12%) :arrow_down:
hazelcast/proxy/multi_map.py 98.44% <90.62%> (-1.12%) :arrow_down:
...azelcast/protocol/codec/multi_map_put_all_codec.py 100.00% <100.00%> (ø)
hazelcast/statistics.py 87.64% <0.00%> (-0.57%) :arrow_down:
hazelcast/invocation.py 93.47% <0.00%> (-0.37%) :arrow_down:
hazelcast/connection.py 92.19% <0.00%> (-0.17%) :arrow_down:
hazelcast/listener.py 93.47% <0.00%> (+1.63%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 12 '22 05:09 codecov-commenter

You need to add a test to MultiMapCompactCompatibilityTest as well

mdumandag avatar Sep 23 '22 10:09 mdumandag

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: nevzatseferoglu
:x: Nevzat Seferoglu


Nevzat Seferoglu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

devOpsHazelcast avatar Oct 12 '22 10:10 devOpsHazelcast

New PR is opened for this feature.

nevzatseferoglu avatar Dec 26 '22 14:12 nevzatseferoglu