hazelcast-python-client icon indicating copy to clipboard operation
hazelcast-python-client copied to clipboard

Published 20 hours ago • verified publisher icon hazelcast

README.rst: Code Samples

Open burakcelebi opened this issue 4 years ago • 5 comments

Adding a link for code samples and a minor update.

burakcelebi avatar Jan 14 '21 12:01 burakcelebi

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jun 30 '21 10:06 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 01 '21 06:07 sonarqubecloud[bot]

A bit too late, but I will try to review anyways :smile:

I don't think we should add code samples to that section. It is not a channel where the user can ask questions. I feel like, If we want to include a link to code samples, we need to do it elsewhere

mdumandag avatar Sep 06 '21 11:09 mdumandag

I think it is helpful to include the link to the code samples in README. I would delete the first sentence You can use the following channels for your questions and development/usage issues:

and leave the rest like as it is in this PR. We may also change the name of the section from Getting Help to something else. Like useful links etc.

srknzl avatar Oct 04 '21 10:10 srknzl

Actually a link to the examples is included in the getting started document. Both options are fine for me then.

srknzl avatar Oct 04 '21 10:10 srknzl