hazelcast-nodejs-client icon indicating copy to clipboard operation
hazelcast-nodejs-client copied to clipboard

[TRACKING ISSUE] Don't allow overriding default serializers with Compact [API-1581]

Open hz-devops-test opened this issue 3 years ago • 2 comments

The tracking issue for the Java side PR.

See https://github.com/hazelcast/hazelcast/pull/22219 for details.


Overriding default serializers with Compact might allow easier use for some of the field types, but it can lead to quite subtle problems to debug, when used incorrectly.

Therefore, we have decided to not allow it for 5.2, and this PR removes the integration of the Compact serialization with the allowOverrideDefaultSerializers configuration option.

hz-devops-test avatar Sep 22 '22 09:09 hz-devops-test

Note: In order to easily do this we can add constructor functions of builtin methods to the registrations: image

As can be seen, we are using strings as keys. We can use constructor functions instead or use an object that includes both string and constructor. I don't know why strings are used. Most probably, it will be fine to switch to constructor functions.

All the logic around findSerializerFor and Util.getType need to be changed though.

srknzl avatar Sep 22 '22 10:09 srknzl

Internal Jira issue: API-1581

github-actions[bot] avatar Sep 29 '22 10:09 github-actions[bot]

@harunalpak @srknzl did we ported the necessary changes for this fix to Node.js? If so, can you please close the issue by linking the PR we did this change?

mdumandag avatar Dec 08 '22 10:12 mdumandag

Yes we ported this changes to Nodejs client. See PR for details.

harunalpak avatar Dec 14 '22 14:12 harunalpak