hazelcast-nodejs-client icon indicating copy to clipboard operation
hazelcast-nodejs-client copied to clipboard

[TRACKING ISSUE] [API-1320] Introduce various updates to Compact serialization implementation [API-1586]

Open hz-devops-test opened this issue 3 years ago • 1 comments

The tracking issue for the Java side PR.

See https://github.com/hazelcast/hazelcast/pull/21734 for details.


This is the compound PR for the tasks listed in JIRA task API-1320.

It contains the following changes

  • Schema class now holds the fields in a HashMap instead of TreeMap for faster lookups
  • Various JavaDoc fixes for some classes
  • Removing non-reachable dead codes around RabinFingerprint, DefaultCompactWriter, and CompactInternalGenericRecord
  • Mechanism to prevent duplicate field names in the Compact serializers
  • Check for making sure that the Compact serializers registered would not override the default serializers, unless explicitly set by the user to do so.

hz-devops-test avatar Jul 20 '22 09:07 hz-devops-test

Internal Jira issue: API-1586

github-actions[bot] avatar Sep 29 '22 10:09 github-actions[bot]

@harunalpak @srknzl did we ported the necessary changes for this fix to Node.js? If so, can you please close the issue by linking the PR we did this change?

mdumandag avatar Dec 08 '22 10:12 mdumandag

Yes we ported this changes to nodejs client. See PR for details.

harunalpak avatar Dec 14 '22 14:12 harunalpak