hazelcast-nodejs-client icon indicating copy to clipboard operation
hazelcast-nodejs-client copied to clipboard

Comparator's `sort` might be unnecessary

Open srknzl opened this issue 4 years ago • 1 comments

Originally reported by @puzpuzpuz

Describe the bug sort method in the TS Comparator interface used by PagingPredicate seems to be redundant. The client doesn't need it since the sort happens on member side

Expected behavior

get rid of it if it's really redundant/or maybe deprecate it

Additional Info

https://github.com/hazelcast/hazelcast-nodejs-client/blob/610eebce388f76ee1313d66b107612b3aba720b6/src/core/Comparator.ts#L36

https://github.com/hazelcast/hazelcast-python-client/blob/d63e83d3379633bf310e52ae3c0bc8b226460b22/examples/map/map_paging_predicate_example.py#L45

srknzl avatar Aug 06 '21 08:08 srknzl

Internal jira issue: https://hazelcast.atlassian.net/browse/API-1226

srknzl avatar Nov 08 '22 09:11 srknzl