hazelcast-download.properties inside the lib directory

[jerrinot]

when I build the latest master and unzip the tar.gz distribution then the lib directory contains hazelcast-download.properties. Is this expected? I guess it should not be there.

[frant-hartm]

Yes, it should be there to distinguish call homes between Jet jar from maven, from tar/zip distribution and from docker.

$ cat hazelcast-jet-4.4-SNAPSHOT/lib/hazelcast-download.properties 
hazelcastDownloadId=distribution

$ docker run hazelcast/hazelcast-jet:latest-snapshot cat /opt/hazelcast-jet/lib/hazelcast-download.properties
hazelcastDownloadId=docker

[jerrinot]

that's a weird location, isnt it? as a user I am confused by this.

[olukas]

Moreover can we add single line comment into the file which explains reason of this file?

[frant-hartm]

Options discussed:

• have the file with the correct value in hazelcast-jet jar - I don't like this as we would have 3 different jars - one in maven central, one in tar/zip, one in docker
• move the file to config/ and put the whole config folder on CP - @jerrinot doesn't like the whole folder on CP, single file can't put on CP
• package the file into a jar and put the jar in lib/, could be done using yet another assembly

I think the best solution would be to add support for passing a value via a system property to the PhoneHome.

[cangencer]

@frant-hartm seems this is how it was done for IMDG: https://github.com/hazelcast/hazelcast-docker/pull/230/files#diff-fcaf45f62a2fdc483b0edd5506e0bb6a7fbd11bba72dedcef1ab36117aecda20R56