Niels Hofmans

Results 203 comments of Niels Hofmans

That's a very good point, I've added it in 6c71848

Hmm, very good point @sidm1983 . I'm thinking about chmodding `busybox` to `000` but i'm not sure about the implications.

I've opened up https://github.com/ironpeakservices/iron-alpine/pull/42 for work around this. I guess I need to check for symlinks in all delete scenarios.

Correction, I meant `chmod` ofcourse. :-)

An example of me using my `reviewdog/action-golangci-lint` fork: https://github.com/ironPeakServices/iron-redis/blob/master/.github/workflows/pr.yaml#L9

Hi @telanflow , i'll check the http protocol version. So what does this todo refer to then? https://github.com/telanflow/mps/blob/master/mitm_handler.go#L134

@telanflow Interesting, I've disabled `connection: close` on request & response and always use `HTTP/1.1`. ![image](https://user-images.githubusercontent.com/5222512/97806462-04523f00-1c5c-11eb-9917-6349c230ba64.png)

Same with `ctx.Request.Context()` or `ctx.Context`

And strangely enough, any headers set in `getInsertor` does not seem to propagate to the `OnRequest`. Edit: I guess this is because `getInsertor` only occurs on the `CONNECT` call, and...

Ahh. not quite sure how I missed that, thanks @telanflow ! Loving the rewrite.