haykam821
haykam821
`LockableChunk` seems good.
It could be `DamageTracker#getPrimaryAttacker` instead with documentation to indicate how the primary attacker is determined.
I think this would be better as `OptionListWidget` instead, since the `Option#createButton` method returns a `ClickableWidget`, which includes sliders and checkboxes as well as typical buttons.
@YanisBft The list has been updated to reflect the mappings in e9b45f9afdd60cbd9b2d4503c707ea1e7d06901c, or 21w11a build 34: Non-matching getter methods and fields net/minecraft/advancement/advancementdisplay.java: x: xpos net/minecraft/advancement/advancementdisplay.java: y: ypos net/minecraft/advancement/criterion/criterionprogress.java: obtaineddate: obtained...
The list has been updated to reflect the mappings in 0694c629a96271db7254bfb533f5e9b8f966b25b, or 1.17-rc2 build 1: Non-matching getter methods and fields net/minecraft/advancement/criterion/criterionprogress.java: obtaineddate: obtained net/minecraft/block/abstractsignblock.java: signtype: type net/minecraft/block/abstractskullblock.java: skulltype: type net/minecraft/block/block.java:...
The list has been updated to reflect the mappings in 80a35594f5c97962896df6a76e7e225a2a1ef09b, or 1.17.1 build 49: Non-matching getter methods and fields net/minecraft/block/abstractsignblock.java: signtype: type net/minecraft/block/abstractskullblock.java: skulltype: type net/minecraft/block/block.java: blastresistance: resistance net/minecraft/block/oxidizableblock.java:...
The list has been updated to reflect the mappings in e0c26300f8475f16f54856125f5a98bc0d41ab71, or 1.18 build 1: Non-matching getter methods and fields net/minecraft/block/abstractsignblock.java: signtype: type net/minecraft/block/abstractskullblock.java: skulltype: type net/minecraft/block/block.java: blastresistance: resistance net/minecraft/block/oxidizableblock.java:...
I don't see anything wrong with this pull request, but since Minecraft 1.19 has been released, it being merged will have to wait until the next snapshot cycle starts.
The `createAndScheduleFluidTick` method should also be renamed to `scheduleFluidTick`.
Perhaps `Entity#readEntitySpecificNbt` and `Entity#writeEntitySpecificNbt` would work?